FLPATH-2749 | Refactor the Plugin code based on new structure to cost-management by asmasarw · Pull Request #2341 · redhat-developer/rhdh-plugins

asmasarw · 2026-02-17T10:43:51Z

FLPATH-2749 | Refactor the Plugin code based on new structure to cost-management

rhdh-gh-app · 2026-02-17T10:44:13Z

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

@red-hat-developer-hub/plugin-cost-management-common
@red-hat-developer-hub/plugin-cost-management

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
app	workspaces/cost-management/packages/app	none	`v0.0.5`
backend	workspaces/cost-management/packages/backend	none	`v0.0.5`
@red-hat-developer-hub/plugin-cost-management-backend	workspaces/cost-management/plugins/cost-management-backend	patch	`v2.0.2`
@red-hat-developer-hub/plugin-cost-management-common	workspaces/cost-management/plugins/cost-management-common	none	`v2.0.1`
@red-hat-developer-hub/plugin-cost-management	workspaces/cost-management/plugins/cost-management	none	`v2.0.1`

alizard0

Left some comments.

alizard0 · 2026-02-17T15:10:30Z

workspaces/cost-management/docs/dynamic-plugin.md

              credentials: dangerously-allow-unauthenticated
-        resourceOptimization:
+        costManagement:
          clientId: ${ROS_CLIENT_ID}


@asmasarw if it is called costManagement, why do we still have env variables with ROS_ shouldn't it be refactored too?

agree,
changed to CM_

alizard0 · 2026-02-17T15:11:29Z

...management/plugins/redhat-resource-optimization-backend/src/service/costManagementService.ts

          const baseUrl =
-            configApi.getOptionalString('costManagementProxyBaseUrl') ??
+            configApi.getOptionalString(
+              'costManagement.costManagementProxyBaseUrl',


@asmasarw this seem to be a breaking change, you added a prefix.

This was done by mistake, Reverted.
Thanks

alizard0 · 2026-02-17T15:11:46Z

...management/plugins/redhat-resource-optimization-backend/src/service/costManagementService.ts

+              'costManagement.costManagementProxyBaseUrl',
+            ) ??
+            configApi.getOptionalString(
+              'costManagement.optimizationsBaseUrl',


@asmasarw here too, the prefix was added not refactored.

This was done by mistake, Reverted.
Thanks

alizard0 · 2026-02-17T15:13:19Z

workspaces/cost-management/plugins/cost-management-backend/config.d.ts

@@ -15,7 +15,7 @@
 */

 export interface Config {
-  resourceOptimization: {
+  costManagement: {


As I commented before, previously this was used without prefix, and after the refactor you introduced a prefix, is thsi expect? is this the config?

Here the name is fine, but the nested values were incorrect.
Reverted.

alizard0 · 2026-02-17T15:14:41Z

...paces/cost-management/plugins/redhat-resource-optimization-common/scripts/lib/typescript.mjs

+   * Override generated pluginId so discovery matches the backend plugin ID
+   * (OpenAPI info.title is set to 'cost-management' for the API name).
+   */
+  setPluginIdValue(pluginIdFilePath, value) {


Why do we need this? If this is a refactoring PR, why do we have new code. I don't understand why is this relevant and previously wasnt.

This was done by mistake, Reverted.
Thanks

alizard0 · 2026-02-17T15:15:12Z

...aces/cost-management/plugins/redhat-resource-optimization-common/scripts/generate_client.mjs

+  console.log('Setting pluginId to backend plugin ID for discovery');
+  tsSourceFileMutator.setPluginIdValue(
+    `${commonPackageDir}/src/generated/pluginId.ts`,
+    'redhat-resource-optimization',


redhat-resource-optimization?

This was done by mistake, Reverted.

alizard0 · 2026-02-17T15:15:56Z

.../optimizations-breakdown-chart/components/optimizations-breakdown-chart/utils/chart-utils.ts

@@ -120,7 +120,7 @@ export const getLegendData = (

  const result: any = [];

-  series.map((s, index) => {
+  series.forEach((s, index) => {


Why is that?

This is a Sonar Qube Issue fixed here.
CI fail here, unless we're changing the map to forEach.

…-management

alizard0 · 2026-02-23T13:52:19Z

.github/renovate-presets/workspace/rhdh-redhat-resource-optimization-presets.json

@@ -2,23 +2,23 @@
  "packageRules": [
    {
      "description": "all Redhat Resource Optimization minor updates",


Update this to Red hat Cost Management instead of Resource Optimization

alizard0

Please review the .github/renovate-presets/workspace/rhdh-redhat-resource-optimization-presets.json‎ file. I found multiple entries for Resource Optimization and I think you are renaming to Cost Management no?

alizard0 · 2026-02-23T13:53:29Z

.github/renovate-presets/workspace/rhdh-redhat-resource-optimization-presets.json

-      "matchFileNames": ["workspaces/redhat-resource-optimization/**"],
+      "matchFileNames": ["workspaces/cost-management/**"],
      "extends": [
        "github>redhat-developer/rhdh-plugins//.github/renovate-presets/base/rhdh-patch-presets(RH Resource Optimization)"


Same applies here, if i am not wrong. Cost Management is the new name for it, right?

Renamed, But It fails on:
Renovate Config Validator - as I understand it's because it tries to search for the preset in the upstream, but since we are renaming this, it doesn't exist yet in the Upstream branch.

Once merged this CI validation will pass.

PreetiW

Incomplete Plugin Rename — redhat-resource-optimization → cost-management

The workspace directory was renamed to cost-management/, but the plugins, packages, IDs, routes, configs, and scripts all still use redhat-resource-optimization. This needs to be completed for the dynamic plugin image to build and install correctly under the new name.

What's done ✅

Workspace directory: workspaces/cost-management/
repository.directory fields in all package.json files
README title uses "Cost Management"
OpenAPI spec title uses cost-management
Parent menu item in dynamic-plugins.yaml uses cost-management

What's still using the old name ❌

1. Plugin directories

plugins/redhat-resource-optimization/ → plugins/cost-management/
plugins/redhat-resource-optimization-backend/ → plugins/cost-management-backend/
plugins/redhat-resource-optimization-common/ → plugins/cost-management-common/

2. NPM package names (all `package.json`)

@internal/redhat-resource-optimization → @internal/cost-management
@red-hat-developer-hub/plugin-redhat-resource-optimization → @red-hat-developer-hub/plugin-cost-management
@red-hat-developer-hub/plugin-redhat-resource-optimization-backend → @red-hat-developer-hub/plugin-cost-management-backend
@red-hat-developer-hub/plugin-redhat-resource-optimization-common → @red-hat-developer-hub/plugin-cost-management-common
All backstage.pluginId, backstage.pluginPackages, and workspace dependencies need updating

3. Plugin IDs in source

plugins/.../src/plugin.ts (FE): id: 'redhat-resource-optimization'
plugins/.../src/plugin.ts (BE): pluginId: 'redhat-resource-optimization'
plugins/.../src/generated/pluginId.ts: pluginId = 'redhat-resource-optimization'
plugins/.../src/apis.ts: id: 'plugin.redhat-resource-optimization.api'

4. Route paths

update the route paths as well to /cost-management

5. Dynamic plugin config

dynamic-plugins.yaml: package path, plugin key, menu item keys (redhat-resource-optimization, redhat-resource-optimization.ocp)
app-config.dynamic.yaml (FE + BE): plugin keys
Note: importName values (ResourceOptimizationPage, OpenShiftPage, ResourceOptimizationIcon) should stay as-is — they are code export names describing the feature.

6. Config & metadata

app-config.yaml: app.title: Red Hat - Resource Optimization
catalog-info.yaml: metadata.name and metadata.title
vs.code-workspace: window.title

7. `scripts/dynamic-plugins.sh`

update the reference and regenerate the image, check if image gets generated correctly and used correctly

8. Common lib internals

scripts/lib/openapi.mjs: spec.info.title
scripts/generate_client.mjs: DEFAULT_PLUGIN_DIRECTORY
src/clients/optimizations/types.ts: comment reference

9. Root `package.json` scripts

start:fe-plugin and start:be-plugin workspace references

10. Documentation

Plugin READMEs: npm package names, route paths, endpoint references
docs/dynamic-plugin.md: any old name references

Post-rename tasks

Regenerate yarn.lock (yarn install)
Regenerate API reports (yarn build:api-reports)
Test dynamic plugin build (scripts/dynamic-plugins.sh oci)
Update .github/renovate-presets/workspace/rhdh-redhat-resource-optimization-presets.json

@asmasarw once you update the above let me know and I will test and review again 🙌🏻

PreetiW · 2026-02-24T10:09:00Z

.github/renovate-presets/workspace/rhdh-redhat-resource-optimization-presets.json

    {
      "description": "all Redhat Resource Optimization dev dependency updates",
-      "matchFileNames": ["workspaces/redhat-resource-optimization/**"],
+      "matchFileNames": ["workspaces/cost-management/**"],


@asmasarw can we rename this file as well please to avoid confusion?

sonarqubecloud · 2026-02-25T09:37:12Z

Quality Gate passed

Issues
127 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

asmasarw requested review from PreetiW, batzionb, mareklibra and ydayagi as code owners February 17, 2026 10:43

asmasarw changed the title ~~Modify Yaml files~~ FLPATH-2749 | Refactor the Plugin code based on new structure to cost-management Feb 17, 2026

asmasarw requested review from a team as code owners February 17, 2026 10:46

asmasarw force-pushed the feature/cost-m branch from d7564fa to 17df515 Compare February 17, 2026 10:59

alizard0 reviewed Feb 17, 2026

View reviewed changes

FLPATH-2749 | Refactor the Plugin code based on new structure to cost…

fec97ca

…-management

asmasarw force-pushed the feature/cost-m branch from 2c6e89d to fec97ca Compare February 18, 2026 10:18

asmasarw requested a review from alizard0 February 18, 2026 10:20

ydayagi approved these changes Feb 23, 2026

View reviewed changes

asmasarw enabled auto-merge (squash) February 23, 2026 12:17

asmasarw disabled auto-merge February 23, 2026 12:56

alizard0 reviewed Feb 23, 2026

View reviewed changes

Update presets

59ff1e2

PreetiW requested changes Feb 24, 2026

View reviewed changes

Rename Plugin Ids, titles, paths, routers and etc.

3c763b3

Comments

Conversation

asmasarw commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhdh-gh-app bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Missing Changesets

Changed Packages

Uh oh!

alizard0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alizard0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PreetiW left a comment

Choose a reason for hiding this comment

What's done ✅

What's still using the old name ❌

1. Plugin directories

2. NPM package names (all package.json)

3. Plugin IDs in source

4. Route paths

5. Dynamic plugin config

6. Config & metadata

7. scripts/dynamic-plugins.sh

8. Common lib internals

9. Root package.json scripts

10. Documentation

Post-rename tasks

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 25, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asmasarw commented Feb 17, 2026 •

edited

Loading

rhdh-gh-app bot commented Feb 17, 2026 •

edited

Loading

2. NPM package names (all `package.json`)

7. `scripts/dynamic-plugins.sh`

9. Root `package.json` scripts